Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43859: Include link to notebook on GitHub #164

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Conversation

jonathansick
Copy link
Member

@jonathansick jonathansick commented Apr 11, 2024

This component links to the notebook in GitHub. Currently it assumes we're referencing the "main" branch; to fix that we'd have to store the default branch in Times Square to serve from its API.

Also include a link to download the notebook file with parameters filled in so that a user can pick the analysis in their own JupyterLab pod.

CleanShot 2024-04-12 at 13 55 53@2x

This exposes additional data from the Times Square /v1/pages/:page
endpoint.
Copy link

changeset-bot bot commented Apr 11, 2024

🦋 Changeset detected

Latest commit: 0574c00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
squareone Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

jonathansick added a commit to lsst-sqre/phalanx that referenced this pull request Apr 12, 2024
This component links to the notebook in GitHub. Currently it assumes
we're referencing the "main" branch; to fix that we'd have to store the
default branch in Times Square to serve from its API.
This link includes the current parameters so that the user can pick up
what they're looking at in their own JupyterLab.

Add the download icon from fontawesome.
@jonathansick jonathansick marked this pull request as ready for review April 12, 2024 17:59
@jonathansick jonathansick merged commit 8d7e683 into main Apr 15, 2024
12 checks passed
@jonathansick jonathansick deleted the tickets/DM-43859 branch April 15, 2024 14:40
@squareone-ci squareone-ci bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant