Enable results redirect servlet for async TAP queries #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stvoutsin
force-pushed
the
tickets/DM-44657
branch
from
1c44c4d to
ea45725
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR modifies the Async results functionality, by adding a redirect servlet which serves under /results/*. TAP Async results (jobID/results/result) now link to this servlet (/results/resultID.xml) so that when clients make a (authenticated) request to the results endpoint, they are redirected to the actual file which is stored in a Google CDN location. This should lead the client to strip the auth headers from the request, as otherwise would be a breach of HTTP security best policies.
How was this tested
I've built & deployed a Docker image with this version on dev, and tested with the following tools:
Potential issues
I've only tested this on idfdev, but we have several RSP operators who are storing results in a slightly different way (S3 in openstack for example). Could this break for their environment?