Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DM-45303] Fix issue with ownerID missing #40

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

stvoutsin
Copy link
Member

@stvoutsin stvoutsin commented Jul 24, 2024

Summary
This PR enables us to use the StandardIdentityManager from upstream, so that we no longer have to maintain a custom implementation. This required changing the Job Manager class to use the IM we get from
our config via AuthenticationUtil.getIdentityManager();

Jira issue
https://rubinobs.atlassian.net/browse/DM-45303

Tests
Tested with new UI testing suite which I'll publish soon. This tests:

  • Test TAP Adql queries with Firefly
  • Test 4 of the Notebooks that involve catalog access (TAP), uploads & visualization
  • Run taplint and assert that it matches previous result
    `

@stvoutsin stvoutsin changed the title [DM-45303] Add Rubin IdentityManager implementation [DM-45303] Fix issue with ownerID missing Jul 30, 2024
@stvoutsin stvoutsin merged commit 3359b08 into master Jul 30, 2024
1 check passed
@stvoutsin stvoutsin deleted the tickets/DM-45303 branch July 31, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant