DM-42937: Switch to pydantic-settings for configuration #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use pydantic-settings to gather the configuration, and use a standard prefix of CUTOUT_ for all environment variables. Drop the SAFIR_LOG_NAME setting and add CONFIG_PATH_PREFIX to control the API path prefix. Make the configuration setting names match the environment variables and use timedelta for more time deltas rather than integer numbers of seconds. Start using some of the Safir datetime support functions.
Since vo-cutouts requires workload identity, it's not really possible to test it by running it locally. Drop the support for that.
Use one line per paragraph consistently throughout CHANGELOG.md, since this is required for cutting and pasting into the GitHub release page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pydantic-settings to gather the configuration, and use a standard prefix of CUTOUT_ for all environment variables. Drop the SAFIR_LOG_NAME setting and add CONFIG_PATH_PREFIX to control the API path prefix.
Make the configuration setting names match the environment variables and use timedelta for more time deltas rather than integer numbers of seconds. Start using some of the Safir datetime support functions.