DM-44763: Refactor the UWS support library #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework the way that code is divided between the service and the UWS library to try to move more of the complexity into the library. The service no longer has to define any routes; instead, it defines FastAPI dependencies that return the job parameters, and all the route code is handled by the UWS library. The policy layer has been removed in favor of adding callbacks to the UWS configuration layer that accomplish the same thing. This refactor standardizes the arguments to the backend worker and passes it a Pydantic model, since we can rely on Pydantic being available in stack containers. Refactor the parameter models for cutouts to support Pydantic serialization so that there's no need to implement a separate to_dict function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the way that code is divided between the service and the UWS library to try to move more of the complexity into the library.
The service no longer has to define any routes; instead, it defines FastAPI dependencies that return the job parameters, and all the route code is handled by the UWS library.
The policy layer has been removed in favor of adding callbacks to the UWS configuration layer that accomplish the same thing. This refactor standardizes the arguments to the backend worker and passes it a Pydantic model, since we can rely on Pydantic being available in stack containers.
Refactor the parameter models for cutouts to support Pydantic serialization so that there's no need to implement a separate to_dict function.