DM-45138: Serialize worker parameters before dispatching #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using pickle to serialize parameters for the workers runs the risk of not being able to unpickle in a backend using a different Python version and different library versions. Reduce the risk by always serializing the parameters model before dispatching, so what will be pickled is only a JSON-compatible dictionary, which should be safely portable. Making this work properly required fixing a few bugs in the code to deserialize astropy data types since JSON serialization turns tuples into lists. Unpin numpy, since that pin should no longer be necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using pickle to serialize parameters for the workers runs the risk of not being able to unpickle in a backend using a different Python version and different library versions. Reduce the risk by always serializing the parameters model before dispatching, so what will be pickled is only a JSON-compatible dictionary, which should be safely portable.
Making this work properly required fixing a few bugs in the code to deserialize astropy data types since JSON serialization turns tuples into lists.
Unpin numpy, since that pin should no longer be necessary.