DM-45138: Move PostgreSQL URL manipulation into type #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new EnvAsyncPostgresDsn type that modifies the URL based on environment variable settings set by tox-docker, avoiding the need for an explicit validator and making it easier to lift this code into Safir. Due to a bug in the type system of Pydantic, this does not work in conjunction with the pattern to convert URLs into strings, so undo that change and keep the URL as a Pydantic MultiHostUrl object. This requires explicitly converting it to a string in a few places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new EnvAsyncPostgresDsn type that modifies the URL based on environment variable settings set by tox-docker, avoiding the need for an explicit validator and making it easier to lift this code into Safir.
Due to a bug in the type system of Pydantic, this does not work in conjunction with the pattern to convert URLs into strings, so undo that change and keep the URL as a Pydantic MultiHostUrl object. This requires explicitly converting it to a string in a few places.