Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-47986: Convert to Wobby and the new Safir UWS library #236

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

rra
Copy link
Member

@rra rra commented Dec 10, 2024

Remove the direct database connection and convert to the new Safir UWS library and the Wobbly backend for job storage. Remove the command-line tool, since its only purpose was to manage the database schema. Simplify the application startup now that schema creation is not required.

Change the dependencies to return the full cutout model, now that Safir supports this. Move the parsing from strings into a helper function used by the dependencies, since the cutout model no longer has to be aware of the SODA input parameters.

Move the MultiValuedParameterError exception here from Safir, since that error code is SODA-specific.

@rra rra force-pushed the tickets/DM-47986 branch 3 times, most recently from 46f03b5 to c0e31f3 Compare December 11, 2024 01:09
@rra rra marked this pull request as ready for review December 11, 2024 01:21
Remove the direct database connection and convert to the new Safir
UWS library and the Wobbly backend for job storage. Remove the
command-line tool, since its only purpose was to manage the database
schema. Simplify the application startup now that schema creation is
not required.

Change the dependencies to return the full cutout model, now that
Safir supports this. Move the parsing from strings into a helper
function used by the dependencies, since the cutout model no longer
has to be aware of the SODA input parameters.

Move the `MultiValuedParameterError` exception here from Safir, since
that error code is SODA-specific.
@rra rra force-pushed the tickets/DM-47986 branch from c0e31f3 to 6a7bbaa Compare December 12, 2024 02:09
@rra rra enabled auto-merge December 12, 2024 02:09
@rra rra merged commit 97843f0 into main Dec 12, 2024
3 checks passed
@rra rra deleted the tickets/DM-47986 branch December 12, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant