DM-42116: Validate docstrings #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
==========================================
- Coverage 78.79% 78.47% -0.33%
==========================================
Files 40 40
Lines 3155 3108 -47
Branches 530 530
==========================================
- Hits 2486 2439 -47
Misses 578 578
Partials 91 91 ☔ View full report in Codecov by Sentry. |
mxk62
approved these changes
Dec 14, 2023
This allows us to remove the bespoke __init__. This was new in python 3.10 but we never updated to use the new feature.
timj
force-pushed
the
tickets/DM-42116
branch
from
ecd2f7d to
d7d0d62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mxk62 can you please take a look at this. No need to check every doc string. What I especially want you to do is look at the changes to the dataclasses that I made to enable slots. This lets us remove a lot of code that wasn't needed since 3.10 came out.
Checklist
doc/changes