DM-45860: Do not do the collections query again unless we have to #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-45860-hotfix
branch
3 times, most recently
from
c3cfcef
to
f63ec81
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1073 +/- ##
==========================================
- Coverage 89.66% 89.64% -0.02%
==========================================
Files 359 359
Lines 46687 46727 +40
Branches 9600 9609 +9
==========================================
+ Hits 41860 41888 +28
- Misses 3468 3478 +10
- Partials 1359 1361 +2 ☔ View full report in Codecov by Sentry. |
|
@andy-slac I also realized that I had forgotten to add negative limit support to the dimension-records and data-ids command-lines so I've made that change here. Did the collections fix help you? |
timj
force-pushed
the
tickets/DM-45860-hotfix
branch
from
1636d29
to
5f64de8
Compare
Not really, there is a deeper issue when you pass a list of all collection names (mixing all chained and non-chained) to |
It can be slow to run the query on a list of hundreds of collections just on the off chance they have wildcards.
…ommand line This was missed before since we added negative support at the last minute. We can't actually use that negative support handling because the command line uses advanced query interface to do the dataset type joining.
timj
force-pushed
the
tickets/DM-45860-hotfix
branch
from
5f64de8
to
8d55d2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@andy-slac does this help?
Checklist
doc/changesconfigs/old_dimensions