tickets/PREOPS-5360: clean up the nightsum and prenight Times Square notebooks by updating schedview to support them better

[ehneilsen]

No description provided.

[rhiannonlynne]

Can you add a screenshot of what gets produced by create_metric_visit_map_grid?
I think I know but want to make sure - I think the model observatory and thus conditions are only used to put in the sun and moon positions right? Is this function useful enough that it should be available even if conditions are not available, and then the sun/moon are just skipped? If not, it's fine -- I know when you're plotting things using these tools, you almost always have all the information like the model observatory up and available.

[rhiannonlynne]

Looks fine, but ruff failure.

[rhiannonlynne]

empty_observation gives you an "observation" array, not a "visits" (MAF) array .. maybe just run empty_observation through schema converter so all the columns match what you expect? Or maybe it doesn't matter.

[ehneilsen]

At present it doesn't matter, but you are correct that using SchemaConverter.obs2opsim will get it right, whereas what's there now will not. Fixing it now.

[ehneilsen]

create_metric_visit_map_grid creates the maps of most recent and accumulated visits in the nightsum pages. The model observatory is used not only for the sun and moon positions, but also to get the observatory latitude which is needed for the horizon circles at sunrise and sunset.
Could it be optional so this could be run without a model observatory, if we did not plot these things? Sure, but I suspect that someone doing this might just want to go directly to the metric plotting tools in maf, or use maf plus raw uranography of the healpix map: much of the point in these functions is to put together all the elements needed for the specific plots needed for the nightsum and similar notebooks, so I don't think making the model observatory optional will be of much use.

[ehneilsen]

Sample output from create_metric_visit_map .