tickets/SP-1667: Merge the Times Square OR4 nightsum with the nightly nightsum #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhiannonlynne
approved these changes
Nov 2, 2024
| @@ -65,6 +65,9 @@ def read_ddf_visits(*args, **kwargs) -> pd.DataFrame: | |||
| all_visits = read_visits(*args, **kwargs) | |||
|
|
|||
| ddf_field_names = tuple(ddf_locations().keys()) | |||
| # Different versions of the schedule include a DD: prefix, or not. | |||
| # Catch them all. | |||
| ddf_field_names = ddf_field_names + tuple([f"DD:{n}" for n in ddf_field_names]) | |||
There was a problem hiding this comment.
In new baselines, the Roman field shows up as "DD: RGES" .. although it's not really a DDF.
This is probably something to fix in the rubin_scheduler outputs, but it's worth noting here too.
Creating similar kinds of plots for the Roman field is likely not terrible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wrapper code that can figure out how to load what the user asks for, whether it is a sim or data from an instrument in consdb.