PREOPS-3752: Add survey fields and telescope pointing to map. #38
Conversation
- Pass newly added conditions and survey parameters to schedview.plot.survey.map_survey_healpix() - Update Bokeh plot of key to match colour and alpha values of plot objects.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=======================================
Coverage 12.41% 12.41%
=======================================
Files 39 39
Lines 3078 3078
Branches 466 466
=======================================
Hits 382 382
Misses 2687 2687
Partials 9 9
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Looks good!
Eventually (but not needed for this issue) we may want to change how the legend is made so that the colors etc. are automatically kept the same, and we do not rely on hard-coding the values in two separate places. I can think of several different approaches:
- Use the legend-creating tools built into bokeh
- Leave the legend creation separate (as it is), but have the colors etc. read from a common location.
- Leave the legend creation separate, but instead of hard-coding the colors there, query the bokeh plot object for the colors used.
As a general rule, whenever two values are hard-coded separately but need to be the same, it makes maintaining the code long term harder.
I agree that this is something we should do 👍 I'll have a think on the options. |
Pass newly added conditions and survey parameters to schedview.plot.survey.map_survey_healpix()
Update Bokeh plot of key to match colour and alpha values of plot objects.