Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tickets/PREOPS-4643: remove dependency of prenight on scheduler pickle #57

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

ehneilsen
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (2eb034e) 12.24% compared to head (cf0cb14) 12.36%.
Report is 2 commits behind head on main.

❗ Current head cf0cb14 differs from pull request most recent head 13ae3b5. Consider uploading reports for the commit 13ae3b5 to get more accurate results

Files Patch % Lines
schedview/collect/footprint.py 0.00% 4 Missing ⚠️
schedview/plot/visitmap.py 0.00% 2 Missing ⚠️
schedview/app/prenight/prenight.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   12.24%   12.36%   +0.12%     
==========================================
  Files          39       39              
  Lines        3243     3202      -41     
  Branches      492      479      -13     
==========================================
- Hits          397      396       -1     
+ Misses       2837     2797      -40     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ehneilsen ehneilsen force-pushed the tickets/PREOPS-4643 branch from bc199c3 to cf0cb14 Compare December 8, 2023 22:19
Copy link
Member

@rhiannonlynne rhiannonlynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ehneilsen ehneilsen merged commit e68599c into main Dec 11, 2023
6 checks passed
@ehneilsen ehneilsen deleted the tickets/PREOPS-4643 branch December 11, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants