Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tickets/PREOPS-4827: update test pickles to be compatible with current rubin_scheduler #65

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

ehneilsen
Copy link
Collaborator

recent changes on main have made the current set of scheduler pickles used for schedview testing incompatible.
This should not get merged until there's a new tag on rubin_scheduler.

@rhiannonlynne
Copy link
Member

Not sure if you need to redo this again, with the newly tagged rubin_scheduler.

Copy link
Member

@rhiannonlynne rhiannonlynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you need to update again, but seems straightforward if so.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b4a9bb6) 13.10% compared to head (3eb16eb) 13.10%.

Files Patch % Lines
schedview/compute/scheduler.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage   13.10%   13.10%           
=======================================
  Files          42       42           
  Lines        3258     3258           
  Branches      490      490           
=======================================
  Hits          427      427           
  Misses       2822     2822           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ehneilsen ehneilsen merged commit 290fb7e into main Jan 31, 2024
8 of 9 checks passed
@ehneilsen ehneilsen deleted the tickets/PREOPS-4827 branch January 31, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants