-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PREOPS-5286: Add Playwright end-to-end tests #95
Conversation
@ehneilsen I'm not too sure how to fix the workflow errors I added
to I'm not super familiar with GitHub workflows so this could be a trivial solve. One fix (which doesn't solve this problem, only works around it) is to add conditional statements to the Playwright import statement (see 7c29363). |
@ehneilsen There is also this error. I want to check with you if this code correction should be made here since this file was not modified in this PR.
|
Fixing this to use is instead of == would be fine. |
It looks like you figured this out? I see that the playwright tests are being run in the github CI, and that they are making it some way into the tests (with several asserts being passed successfully) before failing here. |
2857762
to
5116422
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Created Playwright end-to-end tests for different operational modes. Documentation for installation, execution, and debugging is in playwright_testing.rst.
Tests are disabled by default to minimise workflow runtime and prevent artifact failures due to server load variations. To run tests manually, set ENABLE_PLAYWRIGHT_TESTS=1.