-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable uniqueId strings to be written to centroid file #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming uniqueId is now a string this looks fine.
I guess formatting might not look good if there are other strings in there with very long SN names now. |
Do you know the maximum length of a SN string yet? |
Actually, I think the SNe ids will be rather short, e.g., 'MS_587_6'...one of the advantages of allowing non-numeric characters. |
Will it be added to the end of the uniqueId? Currently the output looks like this:
I was thinking if we knew the length we could up the 1st field width. |
@danielsf can say more definitively, but from the implementation, I inferred that strings like |
Jim is correct. As implemented now, the entire SN uniqueId is something like |
( |
So, no way to tell about the connection to the host galaxy? |
That info is in the SN db that the instance catalog generation code reads. |
Right, I was just wondering if that should be encoded in the uniqueID so you wouldn't need to go back and look at the DB to figure that out. But, if it isn't a important use case for users then it doesn't matter. |
This change supports using strings that are not cast-able as
int
s for object ids of instance catalog entries.