Student Role Permissions Error

[cklimash]

We are running Moodle 2.2 Build 20111205 on a test server and I recently applied the lastest version of the quickmail block (version 2011021812) with most recent file modifications made on 2/7/2012. When I test the block as a teacher, everything works fine. If I enable the block for student use, I have the following issue:

-If I enable student use at the course level and the student role is "not set" for all quickmail permissions, the student will be able to see and send mail via the block, but an error message is posted stating "You do not have permission to send emails with Quickmail." even though the system sends the email anyway

-If I enable student use at the course level with the student role allowing quickmail use, everything works fine.

-If i disable student use at the course level with the student role allowing quickmail use, the student still has access the quickmail block in the course.

[philcali]

Thanks for the heads up, and the detailed issue. I'll take a look at this.

[cklimash]

I'm going to look into it as well to see if I can uncover anything, but
I wanted to make you aware of the problem.

On 2/24/12 12:18 PM, Philip Cali wrote:

Thanks for the heads up, and the detailed issue. I'll take a look at this.

---

Reply to this email directly or view it on GitHub:
#18 (comment)

[philcali]

That's great. Feel free to open a pull request, if you get a working patch.

[philcali]

I've identified the problem: once the email is sent, quickmail tries to redirect to the log page to show the history. At our university, we've disabled students from viewing their history, but the reasoning was to stop them from editing their history (should they send out answers to their fellow classmates, etc).

After thinking about it, I don't see a problem with students seeing their history, only deleting it. I think that's a better course of action.

[cklimash]

Phillip,
Thank you again for such a quick response! I agree with you. Lehigh
would not want students to be able to edit or delete their history, but
being able to see the history log with help to confirm that a student
has sent an email. Access to this information could assist with
potential disputes about communications.

Carly

On 2/24/12 12:35 PM, Philip Cali wrote:

I've identified the problem: once the email is sent, quickmail tries to redirect to the log page to show the history. At our university, we've disabled students from viewing their history, but the reasoning was to stop them from editing their history (should they send out answers to their fellow classmates, etc).

After thinking about it, I don't see a problem with students seeing their history, only deleting it. I think that's a better course of action.

---

Reply to this email directly or view it on GitHub:
#18 (comment)

[philcali]

@cklimash, the patch currently resides on student_permissions. I feel pretty good about the changes, but I want my team to feel the same way before it's merged in. If you are in need of these changes ASAP, you can download the zip here: https://github.com/lsuits/quickmail/zipball/student_permissions, or use standard git commands to fetch the branch.

Thanks again for the issue.