Insert Images not working in message body

[BuddyEthridge]

It does not appear that inserting images in Quickmail body is working. I tried using both the "insert image" button and by dragging and dropping (which I did not expect to work), and neither image was included in the received email. The image added via "insert image" still appears in the body when looking at the Quickmail history (the drag and drop does not, no surprise there).

Update: Not working in signatures either. This should be tied back to issue #21 I think.

[philcali]

So the embedded image works for me, but I realized I'm going through the web which handles the permission checks.

This is actually opening up an interesting problem I didn't think about until now: People using thick app email clients, and users who haven't authenticated into Moodle will not receive the embedded content. The permission checks are there in the first place to alleviate the potential problem where students could forward information coming from an instructor to other students who aren't in the class.

If we think the latter is less likely than the former, then I can allow every request to the embedded content through (authenticated or otherwise).

[philcali]

Permission check here (point of reference): https://github.com/lsuits/quickmail/blob/master/lib.php#L272