Skip to content

Commit

Permalink
Merge pull request #17 from larskanis/update-pg
Browse files Browse the repository at this point in the history
Allow use if pg-1.4.6+ and add Github Action CI to verify that it works
  • Loading branch information
lsylvester authored Jun 24, 2023
2 parents b07df4c + 2288eb4 commit 1a04c60
Show file tree
Hide file tree
Showing 3 changed files with 40 additions and 1 deletion.
33 changes: 33 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: ci
on:
push:
pull_request:

jobs:
ci:
strategy:
fail-fast: false
matrix:
os: [ ubuntu, macos, windows ]
ruby: [ '2.5', ruby-head ]
runs-on: ${{ matrix.os }}-latest
env:
PGSERVICE: postgres

steps:
- uses: actions/checkout@v3
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
- uses: ikalnytskyi/action-setup-postgres@v4

- run: bundle install
- run: createdb activestorage_pglo_test

# For some reason the db migrations needs to be executed explicitly on Windows
- name: Copy and run migrations on Windows
if: matrix.os == 'windows'
run: |
ridk exec cp -rv db/migrate test/dummy/db/
rake -f test/dummy/Rakefile active_storage:install db:migrate RAILS_ENV=test
- run: bundle exec rake test
3 changes: 3 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,6 @@ gem 'image_processing', '~> 1.2'

# To use a debugger
# gem 'byebug', group: [:development, :test]

# Required on Windows only
gem 'tzinfo-data'
5 changes: 4 additions & 1 deletion active_storage-postgresql.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ Gem::Specification.new do |s|
s.files = Dir["{app,config,db,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.md"]

s.add_dependency "rails", ">= 6.0"
s.add_dependency "pg", ">= 1.0", "< 1.3"
s.add_dependency "pg", ">= 1.0", "< 2.0",
# Avoid incompatible pg versions, see: https://github.com/ged/ruby-pg/pull/498
"!= 1.3.0", "!= 1.3.1", "!= 1.3.2", "!= 1.3.3", "!= 1.3.4", "!= 1.3.5",
"!= 1.4.0", "!= 1.4.1", "!= 1.4.2", "!= 1.4.3", "!= 1.4.4", "!= 1.4.5"

s.add_development_dependency "pry", "~> 0.11"
s.add_development_dependency "database_cleaner", "~> 1.7"
Expand Down

0 comments on commit 1a04c60

Please sign in to comment.