-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Detect Language #19
Comments
I agree that the code could be factorized, but not in ltb-ldap. The remaining question is: do we create a dedicated project for just one function? Not sure, except if we have other things to factorize. |
We already use LTB LDAP for mail functions, so for me it is ok to add languages functions |
…esk, white-pages and self-service-password.
Indeed, there are other classes in this library. We should rename the library to reflect the real usage. For example, something like |
Please also open an issue for all projects that need refactoring (if not already done): ssp, service-desk, and white-pages. Just to be sure we don't forget. |
The following classes contain duplicate code:
https://github.com/ltb-project/service-desk/blob/master/lib/detectbrowserlanguage.php
https://github.com/ltb-project/self-service-password/blob/master/lib/detectbrowserlanguage.php
https://github.com/ltb-project/white-pages/blob/master/lib/detectbrowserlanguage.php
These can be migrated to create a new addition to the library to reduce duplication.
The text was updated successfully, but these errors were encountered: