Fix bug with 'open_in_sidebar' option

It was failing for extensions that were not defining the param on the manifest.
ltilve · May 6, 2015 · cfadda1 · cfadda1
1 parent 3a0650b
commit cfadda1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/chrome/common/extensions/api/extension_action/action_info.cc b/chrome/common/extensions/api/extension_action/action_info.cc
@@ -183,8 +183,8 @@ scoped_ptr<ActionInfo> ActionInfo::Load(const Extension* extension,
   }
 
   // Should open popup in sidebar?
-  if (dict->HasKey(keys::kPageActionOpenInSidebar))
-    dict->GetBoolean(keys::kPageActionOpenInSidebar, &result->open_in_sidebar);
+  if (!dict->GetBoolean(keys::kPageActionOpenInSidebar, &result->open_in_sidebar))
+    result->open_in_sidebar = false;
 
   return result.Pass();
 }