Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add read_fhx() unit test for whitespace at end of file #164

Closed
brews opened this issue Jul 3, 2020 · 1 comment · Fixed by #166
Closed

Add read_fhx() unit test for whitespace at end of file #164

brews opened this issue Jul 3, 2020 · 1 comment · Fixed by #166
Labels
enhancement New feature or request
Milestone
v0.6.0

Comments

@brews
Copy link
Member

brews commented Jul 3, 2020

PR #162, 807841f includes a fix for a bug caused by white space characters at the end of FHX files.

It would be great to have a quick unit test for this to ensure this doesn't break read_fhx() in the future.
@brews brews added the enhancement New feature or request label Jul 3, 2020
@brews brews added this to the v0.6.0 milestone Jul 3, 2020
@brews
Copy link
Member Author

brews commented Jul 3, 2020

@chguiterman, would you be able be to quickly put together a PR adding this unit test?

If you're too busy, I might be able to. This seems like the kind of this we should def have a test for.

@brews brews changed the title Add read_fhx() unit test for blank line Add read_fhx() unit test for whitespace at end of file Jul 3, 2020
@chguiterman chguiterman mentioned this issue Jul 10, 2020
Merged
brews added a commit that referenced this issue Jul 10, 2020
@brews
Merge pull request #166 from chguiterman/master
fa3c035 
Update unit test for write_fhx(). Continuation of PR#162. Slight change to write_fhx() output. Close #163. Close #164.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

Update unit test for write_fhx() chguiterman/burnr
1 participant
@brews