Add springdormant_fs to recorder variables #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'fix_percent-scarred' # Conflicts: # NEWS.md
brews
approved these changes
Jul 21, 2020
There was a problem hiding this comment.
@chguiterman I'm not sure whether this PR is ready to merge on your end...?
If so:
This looks good! Many thanks for the fix and documentation. I only have one correction, noted in NEWS with an inline review comment.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @GuobaoXu for finding that the internal {burnr} data for
rec_type_recordinglacked the "springdormant_fs" variable. It was accidentally omitted (probably by me) when we added new seasonal designations. This omission triggered big problems inpercent_scarred()calculations. An easy fix, and it should work now.