Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and improvements #49

Merged
merged 4 commits into from
Sep 21, 2020
Merged

Bug fixes and improvements #49

merged 4 commits into from
Sep 21, 2020

Conversation

xypnox
Copy link
Member

@xypnox xypnox commented Sep 21, 2020

The following bugs have been fixed:

Fixes #45
Fixes #20

Copy link
Member

@parth-paradkar parth-paradkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✌️

@xypnox
Copy link
Member Author

xypnox commented Sep 21, 2020

@thescriptninja Can you check if the title bug fixed? It works for me, but may not work on some other browsers.

@parth-paradkar
Copy link
Member

Checked in Chrome and Firefox. Working fine in both, bug is fixed 👍

Copy link
Member

@ghostwriternr ghostwriternr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It would be lovely if we can support "load more" in the playlist in the player view too. Right now, the songs just stop playing upon reaching the end.

Fine with having it as a separate PR as well.

@xypnox xypnox merged commit 6a449b1 into master Sep 21, 2020
@xypnox xypnox deleted the bug-fixes-1 branch September 22, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update title when player moves to the next link Scroll to the video if lower in queue
3 participants