Add benchmark for JUL agent without source information #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Mar 27, 2017
| @Before | ||
| public void testSetup() throws IOException { | ||
| LttngLogHandler hndl = new LttngLogHandler(); | ||
| hndl.setLogSource(false); |
There was a problem hiding this comment.
Oh I see, that's what this public method was for!
Hmm, could it be done through a System.getProperty(), or through a custom constructor?
There was a problem hiding this comment.
I remember that after discussion, we noticed it's common for handler classes to also offer setters for properties like this, so we can stay consistent with that.
Signed-off-by: Genevieve Bastien <gbastien@versatic.net>
tahini
force-pushed
the
jul_no_source
branch
2 times, most recently
from
52269b2 to
e7db4f3
Compare
|
I added the unit tests to this PR |
ghost
reviewed
Jun 13, 2017
| */ | ||
| @Test | ||
| public void testHandlerOutput() { | ||
| assertTrue(session.enableAllEvents()); |
ghost
reviewed
Jun 13, 2017
| import org.lttng.ust.agent.utils.JulTestUtils; | ||
|
|
||
| /** | ||
| * Enabled events test for the LTTng-UST JUL log handler, using the legacy API. |
There was a problem hiding this comment.
This needs to be updated I think? It doesn't seem to be using the "legacy" API.
There was a problem hiding this comment.
hmm. I did not ever bother trying to modify this javadoc :p
Signed-off-by: Geneviève Bastien <gbastien@versatic.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch goes with pull request lttng/lttng-ust#46 from lttng-ust
Signed-off-by: Genevieve Bastien gbastien@versatic.net