Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LLaVA series to evaluation #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

XinrunXu
Copy link

No description provided.

@ltzheng
Copy link
Owner

ltzheng commented Oct 14, 2024

Have you tested the correctness of the code and the results of Llava models?

@XinrunXu
Copy link
Author

I tested on llava-v1.5-7b,llava-v1.5-13b,llava-v1.6-vicuna-7b,llava-v1.6-vicuna-13b, and llava-v1.6-34b.
The code works, but the result is quite low because Lava tends to respond with a 4 tuple instead of a 2 tuple.
And llava-v1.6-mistral-7b cannot work in my code.

@XinrunXu
Copy link
Author

haotian-liu/LLaVA#1448
With this issue, my code can work on llava-v1.6-mistral-7b.

@ltzheng
Copy link
Owner

ltzheng commented Oct 17, 2024

The code looks good to me but it fails to pass the formatting check. Can you run the format.sh to follow the Coding Style Guide in CONTRIBUTING.md? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants