Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datadir support #229

Merged
merged 1 commit into from
Nov 13, 2021
Merged

Add datadir support #229

merged 1 commit into from
Nov 13, 2021

Conversation

lu-zero
Copy link
Owner

@lu-zero lu-zero commented Oct 20, 2021

Fixes #184

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2021

Codecov Report

Merging #229 (b603249) into master (deed1ed) will increase coverage by 0.07%.
The diff coverage is 86.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   84.51%   84.59%   +0.07%     
==========================================
  Files          12       12              
  Lines        1750     1785      +35     
==========================================
+ Hits         1479     1510      +31     
- Misses        271      275       +4     
Impacted Files Coverage Δ
src/cli.rs 88.54% <ø> (ø)
src/install.rs 76.00% <72.22%> (-0.33%) ⬇️
src/build.rs 84.59% <100.00%> (+0.42%) ⬆️
src/build_targets.rs 88.88% <100.00%> (+0.13%) ⬆️
src/pkg_config_gen.rs 86.79% <100.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deed1ed...b603249. Read the comment docs.

@lu-zero
Copy link
Owner Author

lu-zero commented Oct 20, 2021

@naokiri would that fit your needs?

@naokiri
Copy link
Contributor

naokiri commented Oct 23, 2021

@lu-zero Yes, this looks really nice. I really appreciate this feature.

@lu-zero
Copy link
Owner Author

lu-zero commented Oct 23, 2021

If it works for your use-case I'd land it, add also doc and man support and make a new release in a week.

@lu-zero
Copy link
Owner Author

lu-zero commented Nov 9, 2021

@naokiri did you find time to test it?

@naokiri
Copy link
Contributor

naokiri commented Nov 13, 2021

Sorry I was busy and couldn't respond for a while.

For my use case I was using other configurations name for directory names and I needed a similar configuration like this PR
#237

@lu-zero
Copy link
Owner Author

lu-zero commented Nov 13, 2021

Let me land this and then add upon it.

@lu-zero lu-zero merged commit 095239c into master Nov 13, 2021
@lu-zero lu-zero deleted the datadir branch November 13, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Architecture independent install files support
3 participants