Complete the soversion granularity #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-zero
force-pushed
the
more-soversion
branch
from
bfe8a81
to
b2f545d
Compare
|
@kpcyrd could you please test and confirm that works for your purpose as well? |
kpcyrd
reviewed
Oct 11, 2023
kpcyrd
reviewed
Oct 11, 2023
| ln_sf | ||
| .arg(&self.with_full_ver) | ||
| .arg(install_path_lib.join(&self.with_main_ver)); | ||
| let _ = ln_sf.status().unwrap(); |
There was a problem hiding this comment.
This panics if the ln binary couldn't be executed, and ignores the ExitStatus if ln returned an error (below for self.canonical too).
fn links(...) could be changed to fn links(...) -> anyhow::Result<()>, creating the symlink could also be its own function.
There was a problem hiding this comment.
That's unrelated to this set, but it would be a welcomed change, if you feel like sending a patch for it :)
Co-authored-by: kpcyrd <git@rxv.cc>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.