Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React Hot Loader #102

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

drouillard
Copy link

@drouillard drouillard commented Jul 28, 2016

Attempt to address #99

I didn't remove the old hot loading module quite yet. Hot Loading did not work in general for me on OS X / Node V5 and V6 until I made this update. If this works for you feel free to merge. I can remove the old hot module reloading code with another PR. I tried originally but ran into some issues that I have since had trouble reproducing.

I also updated package.json to fix eslint config. The peer deps for Airbnb config were not being met.

@drouillard
Copy link
Author

Seeing errors again on server - which is interesting since I made changes to client webpack

[HMR] Cannot apply update. [0] [HMR] Error: Aborted because 3 is not accepted

Server is having to restart to work. The client side hot reloading still seems to work? Will continue investigating

@drouillard
Copy link
Author

Actually I am seeing the HMR errors on the server even on a fresh pulldown of this project before my commits. It still works, just seems to restart the server.

@drouillard
Copy link
Author

For the linting errors I was seeing - similar issue

facebook/create-react-app#275

Looks like eslint in command line could work. I use mine via Atom editor plugin which requires explicit inclusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant