#305 - Add the accept_proposals_at on Event Form #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanfonceca
reviewed
Oct 16, 2017
| 'accept_proposals_at': CustomDateTimeWidget(attrs={ | ||
| 'id': 'id_accept_proposals', | ||
| 'class': 'inline-input', | ||
| 'placeholder': 'Date Accept Proposals' |
There was a problem hiding this comment.
this needs to be translated.
There was a problem hiding this comment.
i write this chunk of code, because when the template generates the html page, it puts inline-input as a class and Date Accept Proposals as placeholder to input tag
There was a problem hiding this comment.
What i mean was that you need to use the ugettext function. _('Date Accept Proposals'), it would be something like this.
There was a problem hiding this comment.
I'm sorry, I don't see the ugettext function
| @@ -30,6 +30,11 @@ class Meta: | |||
| 'class': 'inline-input', | |||
| 'placeholder': 'Due Date' | |||
| }), | |||
| 'accept_proposals_at': CustomDateTimeWidget(attrs={ | |||
| 'id': 'id_accept_proposals', | |||
There was a problem hiding this comment.
This should be id_accept_proposals_at
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the issue N° 305.
I added to widgets dictionary accept_proposals_at key and a new CustomDateTimeWidget as value in forms.py file.
I added a date in event_data dictionary in test_create_event function in EventTest class.