Update minimal Ubuntu version in workflows from 20.04 to 22.04 #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgoldstein
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Just to confirm: the main fallout here will be that prebuilt binaries will use a newer version of glibc, which could cause issues for anyone who uses the prebuilt binaries and doesn't have said newer version?
If so, seems fine to me: Ubuntu 20.04 is EOL, Important Consumers ™️ build from source anyhow.
Yes, running any of the prebuilt binaries from the new release will fail with a missing glibc version error on old systems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 20.04 LTS is reaching the end of its standard support period.
GitHub runners are going to stop providing images for it soon.
This PR updates all workflows to use 22.04 instead of 20.04.
While this will impact the compatibility of prebuilt release binaries on 20.04, users of those systems can always build Luau from source.
coverageworkflow is also updating from clang++10 to clang++ (defaults to clang++14 today).Line coverage with this switch drops from 89.65% to 87.45%, function coverage remains 91.26%.
As a bonus, we now get branch coverage information.