Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow including compression level when training a dictionary #326

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

mortengrouleff
Copy link
Contributor

The compression improves when the level for the training is close to the level for the compression step.
(100% Compatible for the public API.)

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.70%. Comparing base (c76455c) to head (c51c9c3).
Report is 24 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #326      +/-   ##
============================================
- Coverage     60.01%   59.70%   -0.31%     
- Complexity      308      314       +6     
============================================
  Files            26       27       +1     
  Lines          1473     1504      +31     
  Branches        170      175       +5     
============================================
+ Hits            884      898      +14     
- Misses          434      448      +14     
- Partials        155      158       +3     

…pression improves when the level for the training is close to the level for the compression step. (100% Compatible for the public API.)
@mortengrouleff
Copy link
Contributor Author

@luben Would you consider this PR for merge and potential patch-version bump?

@mortengrouleff
Copy link
Contributor Author

Bump?

@mortengrouleff
Copy link
Contributor Author

@luben
Copy link
Owner

luben commented Sep 22, 2024

Thanks for the contribution! I was away for 2 weeks - late summer vacation - and didn't check github.

@luben luben merged commit 3ca26ee into luben:master Sep 22, 2024
7 of 8 checks passed
@luben
Copy link
Owner

luben commented Sep 22, 2024

released with v1.5.6-6

@mortengrouleff
Copy link
Contributor Author

Thanks for the contribution! I was away for 2 weeks - late summer vacation - and didn't check github.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants