More comments

Signed-off-by: Lubron Zhan <lubronzhan@gmail.com>
lubronzhan · Jan 29, 2024 · c2d5d1d · c2d5d1d
1 parent c179a3c
commit c2d5d1d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/internal/provisioner/model/names.go b/internal/provisioner/model/names.go
@@ -68,8 +68,8 @@ func (c *Contour) ContourRBACNames() RBACNames {
 
 		// this one has a different prefix to differentiate from the certgen role binding (see below).
 		RoleBinding:                        fmt.Sprintf("contour-rolebinding-%s", c.Name),
-		NamespaceScopedResourceRole:        fmt.Sprintf("contour-resource-%s-%s", c.Namespace, c.Name),
-		NamespaceScopedResourceRoleBinding: fmt.Sprintf("contour-resource-%s-%s", c.Namespace, c.Name),
+		NamespaceScopedResourceRole:        fmt.Sprintf("contour-resources-%s-%s", c.Namespace, c.Name),
+		NamespaceScopedResourceRoleBinding: fmt.Sprintf("contour-resources-%s-%s", c.Namespace, c.Name),
 	}
 }
 

diff --git a/test/e2e/gatewayapi_predicates.go b/test/e2e/gatewayapi_predicates.go
@@ -120,8 +120,8 @@ func HTTPRouteAccepted(route *gatewayapi_v1beta1.HTTPRoute) bool {
 	return false
 }
 
-// HTTPRouteIngnoredByContour returns true if the route has an empty .status.parents.conditions list
-func HTTPRouteIngnoredByContour(route *gatewayapi_v1beta1.HTTPRoute) bool {
+// HTTPRouteIgnoredByContour returns true if the route has an empty .status.parents.conditions list
+func HTTPRouteIgnoredByContour(route *gatewayapi_v1beta1.HTTPRoute) bool {
 	if route == nil {
 		return false
 	}

diff --git a/test/e2e/provisioner/provisioner_test.go b/test/e2e/provisioner/provisioner_test.go
@@ -643,7 +643,7 @@ var _ = Describe("Gateway provisioner", func() {
 				} else {
 					// Root proxy in non-watched namespace should fail
 					By(fmt.Sprintf("Expect namespace %s not to be watched by contour", t.namespace))
-					hr, ok := f.CreateHTTPRouteAndWaitFor(route, e2e.HTTPRouteIngnoredByContour)
+					hr, ok := f.CreateHTTPRouteAndWaitFor(route, e2e.HTTPRouteIgnoredByContour)
 
 					By(fmt.Sprintf("Expect httproute under namespace %s is not accepted for a period of time", t.namespace))
 					require.Never(f.T(), func() bool {