Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marlin 2.0 Binary File Transfer? #327

Closed
mat2k opened this issue May 11, 2019 · 10 comments
Closed

Marlin 2.0 Binary File Transfer? #327

mat2k opened this issue May 11, 2019 · 10 comments

Comments

@mat2k
Copy link

mat2k commented May 11, 2019

I just stumbled upon this while updating:

// Add an optimized binary file transfer mode, initiated with 'M28 B1'
//#define BINARY_FILE_TRANSFER

I honestly don't know anything about this, except that it may be much better than what we currently have. worth a look

@luc-github
Copy link
Owner

per MarlinFirmware/Marlin#12249
it is still experimental, only for Marlin 2.X, still not documented and still not stable
It is designed to transfer FW not GCODE so not sure about performances for GCODE.

Sorry I have currently no bandwidth to spend time on experimental specific Firmware feature.

But feel free to have a look and report

@mat2k
Copy link
Author

mat2k commented May 11, 2019

...and due to less overhead and constant maximum packet size it improves transfer rate of gcode files.

it's fine, i'm just saying that this might be an alternative to having a shared SDcard if it improves speed significantly. mostly just a heads-up.

@luc-github
Copy link
Owner

...and due to less overhead and constant maximum packet size it improves transfer rate of gcode files.

yes I saw this, but it does not give any figures so it is hard to confirm unless to do benchmark
and for the moment it looks not stable so again hard to confirm

@luc-github
Copy link
Owner

I think an easy way to test would be to modify the file transfer.py to use telnet instead of serial
That would give I rought idea of the speed.
ESP3D doing telnet /serial bridge it will work out of the box in theory

@Andrei-Pozolotin
Copy link

@p3p Chris:
I am curious if apart from this zip there is an "official protocol documentation"?
https://github.com/MarlinFirmware/Marlin/files/2532378/transfer.py.zip

@p3p
Copy link

p3p commented May 14, 2019

There is no official documentation, it was a POC PR that got merged really, I would like to tweak the protocol a bit make error recovery more reliable, and a few other things, before it becomes an official feature.

Currently its main use case is transferring firmware files to the sd cards on 32bit boards, although because of the fixed packet size (always the maximum your Marlin build supports), rather than transferring gcode line by line it can perform a fair bit better than a normal ascii transfer, especially with a large command buffer (determines the packet size).

@luc-github
Copy link
Owner

I close issue as mentioned #327 (comment) I do not have bandwidth for this with current status - feel free to re open when there are some update

@ModMike
Copy link

ModMike commented Jun 5, 2020

Has there been any developments on this? The ESP3D-WebUI is fantastic but the file transfer is basically unusable.

@luc-github
Copy link
Owner

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants