Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST]🦄Change ESP_DIRECT_SD to ESP_NOT_SHARED_SD for consistency #955

Closed
luc-github opened this issue Oct 12, 2023 · 3 comments
Closed

[FEATURE REQUEST]🦄Change ESP_DIRECT_SD to ESP_NOT_SHARED_SD for consistency #955

luc-github opened this issue Oct 12, 2023 · 3 comments
Labels
ESP-3.X Feature request Fixed SD Card

Comments

@luc-github
Copy link
Owner

in configuration.h

/* SD card connection
* ESP_NO_SD //(default)
* ESP_DIRECT_SD //Only your ESP board is connected to SDCard
* ESP_SHARED_SD //Printer SD Card is also connected to ESP3D
* Does your system has SD card and how it is connected to your ESP3D
*/

ESP_DIRECT_SD seems confusing for users and is often used when ESP_SHARED_SD should be used, the configurator must be updated also
@tjeerdvandijk
Copy link

tjeerdvandijk commented Feb 5, 2024 •
edited
Loading

Agreed, im trying to figure out what it means.

currently it says Your system has SD card and your ESP is connected to it using shared solution

What exactly is a shared solution? Does it simply mean the printer has a sd card? and we do not have to connect anything to the esp?

@luc-github luc-github changed the title [FEATURE REQUEST]Change ESP_DIRECT_SD to ESP_ONLY_SD for consistency [FEATURE REQUEST]🦄Change ESP_DIRECT_SD to ESP_ONLY_SD for consistency Mar 4, 2024
@Sergey3112

This comment was marked as off-topic.

Sign in to view
@luc-github luc-github changed the title [FEATURE REQUEST]🦄Change ESP_DIRECT_SD to ESP_ONLY_SD for consistency [FEATURE REQUEST]🦄Change ESP_DIRECT_SD to ESP_NOT_SHARED_SD for consistency Nov 25, 2024
luc-github added a commit that referenced this issue Nov 25, 2024
@luc-github
Close #955
d2c52ac 
Add more default settings for SPI W5500 Ethernet
Bump version for tracking
luc-github added a commit to luc-github/esp3d.io that referenced this issue Nov 25, 2024
@luc-github
Update due to luc-github/ESP3D#955
888d280 
Complete Pins for ESP32 Eth Lite
@luc-github luc-github added Fixed and removed Planned labels Nov 25, 2024
@luc-github
Copy link
Owner Author

Configurator and Documentation have been updated also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ESP-3.X Feature request Fixed SD Card
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@luc-github @tjeerdvandijk @Sergey3112