Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might (or do) want to change the
HAL_PATH
macro so it includes theHAL
folder name, and later we might move the HAL to a different location within the project. For example, if we decide to build it as a library it may be moved into a rootlib
folder.To wit:
This PR adds
SRCHOME
andHALHOME
preprocessor macros so that these locations can be overridden by defines added to ourfeatures.ini
file, like so:The changes made to
esp3dlibconfig.h
allow for an elegant fallback to the oldHAL_PATH
behavior and location so that builds of older versions of Marlin will continue to work as usual.Also, if 1.0.11 and 1.0.12 can be tagged in this repo, then we can specify a version to pull down, if for some reason that becomes necessary in the future.
Thanks and have a great day!