Get_errorr update #187
Get_errorr update #187
Conversation
|
The program is tested for U-238, which contains mf=31, 33, 34 and 35. In the case of |
can you add this test to the notebooks folder? |
|
Bug solve: Now when we take all the available mf, never returns a empty list. |
|
NJOY now processes the |
|
I have added an extra condition in |
| @@ -1868,7 +1868,13 @@ def get_errorr(self, | |||
| 12 / | |||
| 1.00000e-05 3.00000e-02 5.80000e-02 1.40000e-01 2.80000e-01 3.50000e-01 6.25000e-01 4.00000e+00 4.80520e+01 5.53000e+03 8.21000e+05 2.23100e+06 1.00000e+07 / | |||
| 3/ | |||
| 3 452 'nu' / | |||
There was a problem hiding this comment.
There is no test for MT and groupr together
There was a problem hiding this comment.
In the method get_gendf: Line 2339
Bad mt selection in _errorr_input: line 761
Bad mt selection in _groupr_input: line 1044
The only missing test is on get_errorr.
There was a problem hiding this comment.
Line 2021: Keywords mt and groupr are incompatible
There was a problem hiding this comment.
The most logical option, in my opinion, is to process all the mt and do the following: a warning saying that the mt will have to be processed by the user or create lines of code at the end that filter the mt
There was a problem hiding this comment.
Then let's just make a test showing the incompatibility and let it be for the moment
| @@ -1868,7 +1868,13 @@ def get_errorr(self, | |||
| 12 / | |||
| 1.00000e-05 3.00000e-02 5.80000e-02 1.40000e-01 2.80000e-01 3.50000e-01 6.25000e-01 4.00000e+00 4.80520e+01 5.53000e+03 8.21000e+05 2.23100e+06 1.00000e+07 / | |||
| 3/ | |||
| 3 452 'nu' / | |||
There was a problem hiding this comment.
Then let's just make a test showing the incompatibility and let it be for the moment
sandy/njoy.py
Outdated
|
|
||
| Test of wrong mt number: | ||
| >>> with pytest.raises(SyntaxError): sandy.njoy._errorr_input(20, 21, 0, 22, 9237, mt=455) | ||
| >>> print(sandy.njoy._errorr_input(20, 21, 0, 22, 9237, mt=[102,455])) |
There was a problem hiding this comment.
Why don't we get a error/warning here?
There was a problem hiding this comment.
I would just raise a error right away if one of the banned_mt is found in the mt list
There was a problem hiding this comment.
This assumes that the user knows how NJOY is programmed in sandy, which is not always the case. The current programming only raises an error if we are absolutely sure that NJOY is going to fail.
There was a problem hiding this comment.
We should avoid making assumptions for the users. If some MT numbers are forbidden, then they must be at all times. In this case sometimes a MT is forbidden and sometimes it is not.
sandy/njoy.py
Outdated
| 0/ | ||
|
|
||
| Test the wrong mt number: | ||
| >>> print(sandy.njoy._groupr_input(20, 21, 0, 22, 9237, mt=[455])) |
There was a problem hiding this comment.
It has to raise an errorr
Errorr.py:
Now
get_covreturns a dictionary with the keys being mf and the values of the dictionaryCategoryCovobject. In case there is only one mf, it returns aCategoryCovobject directly.The distinction between
nubarandxsis fundamental, since it helps to recognise errors more easily (in this case, it has helped to recognise errors innjoy.py).On the other hand, in nucleus with more than one mf, the mf argument allows us to select which mf we will receive as output.
Njoy.py:
Bug: Previously, if the user entered a mt, that mt was applied to all error output. This generated null files or errors when parsing mt=456 with mf=33 or mt=2 with mf=31, to give an example. Now, if
xs=Trueand we input differentmt, they are parsed and if they are all greater than 450,3/is automatically written, sonubarandxsare parsed in the same input.