caps: change API to borrow, update to 2018 edition #42
Conversation
dvc94ch
commented
Sep 16, 2019
dvc94ch
commented
- Adds an example, and changes api to borrow CapsHashSet.
- Fixes some warnings
- Upadated for 2018 edition
|
@lucab: if you're not set strongly on using a pre-historic rust version I think this PR is pretty uncontroversial :) |
|
@dvc94ch thanks for the PR! I'll try to find a free slot of time this week to go through and review it. Updating the minimum version to something reasonable is not a problem. |
| @@ -1,8 +1,7 @@ | |||
| language: rust | |||
|
|
|||
| rust: | |||
| - nightly-2018-07-24 # pinned toolchain for clippy | |||
| - 1.26.0 # minimum supported toolchain | |||
| - nightly-2019-09-13 # pinned toolchain for clippy | |||
There was a problem hiding this comment.
You can pin this to 1.38.0 now that clippy is available on the stable channel.
| @@ -1,8 +1,7 @@ | |||
| language: rust | |||
|
|
|||
| rust: | |||
| - nightly-2018-07-24 # pinned toolchain for clippy | |||
| - 1.26.0 # minimum supported toolchain | |||
There was a problem hiding this comment.
Instead of dropping this, it would be better to update to a recent stable. If we can still support 1.31.0 I'd be happier, but otherwise 1.37.0 would be fine.
| @@ -14,7 +15,7 @@ exclude = [ | |||
|
|
|||
| [dependencies] | |||
| errno = "0.2" | |||
| error-chain = {version = "0.12", default-features = false} | |||
| failure = "0.1" | |||
There was a problem hiding this comment.
While I acknowledge that error_chain is dead, I'd rather not do this for two reasons:
failureis dead too- this introduces a dependency on a C library via
backtrace
For the future, I'm keeping an eye on snafu but I'd like to see this fixed first: shepmaster/snafu#113.
There was a problem hiding this comment.
Interesting. The problem with error_chain I encountered (if I remember correctly) was that the errors where not Send.
There was a problem hiding this comment.
Indeed, that's painful if your consumer is on failure as different decisions were taken between the two libraries. You'll need to re-wrap the error at the border, for the moment.
| println!("Permitted {:?}", perm); | ||
| let eff = caps::read(None, CapSet::Effective).unwrap(); | ||
| println!("Effective {:?}", eff); | ||
| } |
There was a problem hiding this comment.
Do you maybe want to add a couple of assert_eq here at the bottom?
|
closing for now |
|
@dvc94ch I started splitting out some of the changes from here to
|
