Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser usage #2

Merged
merged 5 commits into from
May 22, 2024
Merged

Browser usage #2

merged 5 commits into from
May 22, 2024

Conversation

lucas42
Copy link
Owner

@lucas42 lucas42 commented May 22, 2024

The job browser-usage appears to be consistently failing in github actions.

I've found that upgrading some dependencies fixes it. But I'm not entirely sure what the underlying cause it. Through trial & error, I've reach this set of upgrades as the minimal needed to get all the tests passing again.

Use a version of ngrok which runs on recent versions of Windows and MacOS.
Switch to using the npm `overrides` property, to avoid needing to mantain a separate fork of `zuul-ngrok`
@lucas42 lucas42 merged commit 39f44a9 into main May 22, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant