Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sunset sunrise times #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dstrants
Copy link

Hello, it is my first PR!

I have done nothing special, just a minor addition:

  • I have added @sunrise and @sunset parameters
  • I have parsed them into local computer timezone

I believe I followed your way! As far as I test it locally it worked just fine!

Please tell me if anything needs to be changed! I also have some other additions to suggest if you have the time to discuss them!

@dstrants
Copy link
Author

dstrants commented Sep 1, 2017

Hello,
I have just noticed that my commits fail on Travis! The error is weird though cause the CI fails on the bundle install --jobs=3 --retry=3 and I can't tell how this got to do with my addition on the weather file! Any feedback will be highly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant