Skip to content
This repository has been archived by the owner on Dec 1, 2017. It is now read-only.

[library] added DesignSpecActivity #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

arok
Copy link

@arok arok commented Sep 8, 2014

Added simple DesignSpecActivity

@arok arok closed this Sep 8, 2014
@arok arok reopened this Sep 8, 2014
@lucasr
Copy link
Owner

lucasr commented Sep 16, 2014

Hmm, quite mixed about this one. I'd like to keep it simple. Providing a FrameLayout seems like the right level of convenience to debug existing code in any project. Activities tends to vary more from project to project and are harder to integrate if you have your own base Activity.

@arok
Copy link
Author

arok commented Sep 23, 2014

I think just the opposite, if you have your own base activity use dspec are more simple. With base class you may setup individual build configuration for debug and using dspec.

@ataulm
Copy link

ataulm commented Dec 12, 2014

What if you have multiple libraries that require you to extend their Activity? This Activity could be an example for users that want to integrate dspec into their base 👍 but doesn't IMHO need to be part of the core library.

👍 for keeping it simple.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants