feat: migrate workspace to nx 19.x (#242)

The Nx workspace also needs to be migrated to v19.x to to use `@nxlv/python` or
`@nxlv/data-migration` v19.x packages

BREAKING CHANGE: migrate Nx workspace to 19.x

.eslintrc.json

@@ -24,12 +24,18 @@
     {
       "files": ["*.ts", "*.tsx"],
       "extends": ["plugin:@nx/typescript"],
-      "rules": {}
+      "rules": {
+        "@typescript-eslint/no-extra-semi": "error",
+        "no-extra-semi": "off"
+      }
     },
     {
       "files": ["*.js", "*.jsx"],
       "extends": ["plugin:@nx/javascript"],
-      "rules": {}
+      "rules": {
+        "@typescript-eslint/no-extra-semi": "error",
+        "no-extra-semi": "off"
+      }
     },
     {
       "files": ["*.spec.ts", "*.spec.tsx", "*.spec.js", "*.spec.jsx"],

.github/actions/setup-monorepo/action.yml

@@ -0,0 +1,21 @@
+name: Set Up Monorepo
+description: Set up nx monorepo for CI workflows
+
+runs:
+  using: 'composite'
+  steps:
+    - name: Use PNPM 8.x
+      uses: pnpm/action-setup@v3
+      with:
+        version: 8
+    - name: Use Node.js 20.x
+      uses: actions/setup-node@v3
+      with:
+        node-version: 20
+        cache: 'pnpm'
+
+    - name: Install Node.js Dependencies
+      shell: bash
+      run: pnpm install
+
+    - uses: nrwl/nx-set-shas@v4

.github/workflows/ci.yml

@@ -20,13 +20,12 @@ jobs:
       - uses: actions/checkout@v3
         with:
           fetch-depth: 0
-      - uses: nrwl/nx-set-shas@v3
-      - run: npm ci
+      - uses: ./.github/actions/setup-monorepo
 
-      - run: npx nx format:check
-      - run: npx nx affected -t lint test build
+      - run: pnpm nx format:check
+      - run: pnpm nx affected -t lint test build
       - run: |
-          echo "NO_COVERAGE_RUN=$(if [ -z "$(npx nx print-affected --select=projects)" ]; then echo "true"; else echo "false";fi)" >> $GITHUB_ENV
+          echo "NO_COVERAGE_RUN=$(if [ -z "$(pnpm nx print-affected --select=projects)" ]; then echo "true"; else echo "false";fi)" >> $GITHUB_ENV
       - name: Merge coverage
         if: env.NO_COVERAGE_RUN != 'true'
         run: |
@@ -43,4 +42,4 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           HUSKY: '0'
         run: |
-          npx nx affected --target release --parallel=false
+          pnpm nx affected --target release --parallel=false

.gitignore

@@ -41,4 +41,5 @@ Thumbs.db
 # Reports
 reports/
 
-.nx/cache
+.nx/cache
+.nx/workspace-data

.husky/commit-msg

@@ -1,4 +1 @@
-#!/usr/bin/env sh
-. "$(dirname -- "$0")/_/husky.sh"
-
-npx --no-install commitlint --edit "$1"
+pnpm commitlint --edit "$1"

.husky/pre-commit

@@ -1,4 +1 @@
-#!/usr/bin/env sh
-. "$(dirname -- "$0")/_/husky.sh"
-
-npx lint-staged
+pnpm lint-staged

.prettierignore

@@ -3,4 +3,6 @@
 /dist
 /coverage
 
-/.nx/cache
+/.nx/cache
+/.nx/workspace-data
+pnpm-lock.yaml

CONTRIBUTING.md

@@ -24,7 +24,7 @@ npm i
 To build all the packages, run:
 
 ```bash
-npx nx run-many --target=build --all
+pnpm nx run-many --target=build --all
 ```
 
 ## Running Unit Tests
@@ -70,7 +70,7 @@ npm link
 - Create a new nx workspace or use an existing one:
 
 ```bash
-npx create-nx-workspace@latest
+pnpm create-nx-workspace@latest
 ```
 
 - Install the linked package (make sure you are in the root of the nx workspace):

commitlint.config.js

@@ -1,15 +1,6 @@
-const {
-  utils: { getProjects },
-} = require('@commitlint/config-nx-scopes');
-
 module.exports = {
-  extends: ['@commitlint/config-conventional', '@commitlint/config-nx-scopes'],
+  extends: ['@commitlint/config-conventional'],
   rules: {
-    'scope-enum': async (ctx) => [
-      2,
-      'always',
-      [...(await getProjects(ctx)), 'workspace'],
-    ],
     'body-max-line-length': [0, 'always'],
   },
 };

e2e/data-migration-e2e/vite.config.ts

@@ -19,9 +19,6 @@ export default defineConfig({
     minWorkers: 1,
     maxWorkers: 1,
     globals: true,
-    cache: {
-      dir: '../../node_modules/.vitest',
-    },
     environment: 'node',
     include: ['tests/**/*.{test,spec}.{js,mjs,cjs,ts,mts,cts,jsx,tsx}'],
 

e2e/nx-python-e2e/vite.config.ts

@@ -19,9 +19,6 @@ export default defineConfig({
     minWorkers: 1,
     maxWorkers: 1,
     globals: true,
-    cache: {
-      dir: '../../node_modules/.vitest',
-    },
     environment: 'node',
     include: ['tests/**/*.{test,spec}.{js,mjs,cjs,ts,mts,cts,jsx,tsx}'],
 

lint-staged.config.js

@@ -1,8 +1,7 @@
 module.exports = {
   '{packages,tools}/**/*.{ts,js,json,md,html,css,scss}': [
-    'npx nx affected --target lint --uncommitted --fix true',
-    'npx nx format:write --uncommitted',
-    'git add',
+    'pnpm nx affected --target lint --uncommitted --fix true',
+    'pnpm nx format:write --uncommitted',
   ],
-  '*.{js,md,json}': ['npx nx format:write --uncommitted', 'git add'],
+  '*.{js,md,json}': ['pnpm nx format:write --uncommitted'],
 };