fix(nx-python): remove deprecated property and replace with `context.…

…projectsConfigurations` (#249)
lucasvieirasilva · Oct 7, 2024 · c920a62 · c920a62
1 parent cee951b
commit c920a62
Show file tree

Hide file tree

Showing 25 changed files with 146 additions and 138 deletions.
diff --git a/packages/nx-python/src/dependency/update-dependency.ts b/packages/nx-python/src/dependency/update-dependency.ts
@@ -20,7 +20,7 @@ export function updateDependencyTree(context: ExecutorContext) {
 
   updateDependents(
     context,
-    context.workspace,
+    context.projectsConfigurations,
     context.projectName,
     rootPyprojectToml,
     context.root,
@@ -79,7 +79,7 @@ export function updateDependents(
 }
 
 function getProjectPackageName(context: ExecutorContext, projectName: string) {
-  const projectConfig = context.workspace.projects[projectName];
+  const projectConfig = context.projectsConfigurations.projects[projectName];
   const projectToml = getProjectTomlPath(projectConfig);
   const {
     tool: {

diff --git a/packages/nx-python/src/executors/add/executor.spec.ts b/packages/nx-python/src/executors/add/executor.spec.ts
@@ -53,8 +53,7 @@ describe('Add Executor', () => {
       root: '.',
       isVerbose: false,
       projectName: 'app',
-      workspace: {
-        npmScope: 'nxlv',
+      projectsConfigurations: {
         version: 2,
         projects: {
           app: {
@@ -100,8 +99,7 @@ describe('Add Executor', () => {
       root: '.',
       isVerbose: false,
       projectName: 'app',
-      workspace: {
-        npmScope: 'nxlv',
+      projectsConfigurations: {
         version: 2,
         projects: {
           app: {
@@ -152,8 +150,7 @@ describe('Add Executor', () => {
       root: '.',
       isVerbose: false,
       projectName: 'app',
-      workspace: {
-        npmScope: 'nxlv',
+      projectsConfigurations: {
         version: 2,
         projects: {
           app: {
@@ -208,8 +205,7 @@ describe('Add Executor', () => {
       root: '.',
       isVerbose: false,
       projectName: 'app',
-      workspace: {
-        npmScope: 'nxlv',
+      projectsConfigurations: {
         version: 2,
         projects: {
           app: {
@@ -259,8 +255,7 @@ version = "1.0.0"
       root: '.',
       isVerbose: false,
       projectName: 'app',
-      workspace: {
-        npmScope: 'nxlv',
+      projectsConfigurations: {
         version: 2,
         projects: {
           app: {
@@ -306,8 +301,7 @@ version = "1.0.0"
       root: '.',
       isVerbose: false,
       projectName: 'app',
-      workspace: {
-        npmScope: 'nxlv',
+      projectsConfigurations: {
         version: 2,
         projects: {
           app: {
@@ -391,9 +385,8 @@ version = "1.0.0"
       root: '.',
       isVerbose: false,
       projectName: 'shared1',
-      workspace: {
+      projectsConfigurations: {
         version: 2,
-        npmScope: 'nxlv',
         projects: {
           app: {
             root: 'apps/app',
@@ -538,9 +531,8 @@ version = "1.0.0"
       root: '.',
       isVerbose: false,
       projectName: 'shared1',
-      workspace: {
+      projectsConfigurations: {
         version: 2,
-        npmScope: 'nxlv',
         projects: {
           app: {
             root: 'apps/app',
@@ -655,9 +647,8 @@ version = "1.0.0"
       root: '.',
       isVerbose: false,
       projectName: 'app',
-      workspace: {
+      projectsConfigurations: {
         version: 2,
-        npmScope: 'nxlv',
         projects: {
           app: {
             root: 'apps/app',
@@ -726,9 +717,8 @@ version = "1.0.0"
       root: '.',
       isVerbose: false,
       projectName: 'app',
-      workspace: {
+      projectsConfigurations: {
         version: 2,
-        npmScope: 'nxlv',
         projects: {
           app: {
             root: 'apps/app',
@@ -801,9 +791,8 @@ version = "1.0.0"
       root: '.',
       isVerbose: false,
       projectName: 'app',
-      workspace: {
+      projectsConfigurations: {
         version: 2,
-        npmScope: 'nxlv',
         projects: {
           app: {
             root: 'apps/app',
@@ -877,9 +866,8 @@ version = "1.0.0"
       root: '.',
       isVerbose: false,
       projectName: 'app',
-      workspace: {
+      projectsConfigurations: {
         version: 2,
-        npmScope: 'nxlv',
         projects: {
           app: {
             root: 'apps/app',
@@ -947,9 +935,8 @@ version = "1.0.0"
       root: '.',
       isVerbose: false,
       projectName: 'app',
-      workspace: {
+      projectsConfigurations: {
         version: 2,
-        npmScope: 'nxlv',
         projects: {
           app: {
             root: 'apps/app',
@@ -1021,9 +1008,8 @@ version = "1.0.0"
       root: '.',
       isVerbose: false,
       projectName: 'app',
-      workspace: {
+      projectsConfigurations: {
         version: 2,
-        npmScope: 'nxlv',
         projects: {
           app: {
             root: 'apps/app',
@@ -1082,8 +1068,7 @@ version = "1.0.0"
       root: '.',
       isVerbose: false,
       projectName: 'app',
-      workspace: {
-        npmScope: 'nxlv',
+      projectsConfigurations: {
         version: 2,
         projects: {
           app: {
@@ -1165,8 +1150,7 @@ version = "1.0.0"
       root: '.',
       isVerbose: false,
       projectName: 'app',
-      workspace: {
-        npmScope: 'nxlv',
+      projectsConfigurations: {
         version: 2,
         projects: {
           app: {

diff --git a/packages/nx-python/src/executors/add/executor.ts b/packages/nx-python/src/executors/add/executor.ts
@@ -22,7 +22,8 @@ export default async function executor(
   try {
     activateVenv(workspaceRoot);
     await checkPoetryExecutable();
-    const projectConfig = context.workspace.projects[context.projectName];
+    const projectConfig =
+      context.projectsConfigurations.projects[context.projectName];
     const rootPyprojectToml = existsSync('pyproject.toml');
 
     if (options.local) {