Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-python): resolve poetry export local path for windows #244

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

lucasvieirasilva
Copy link
Owner

Current Behavior

Currently, when the projects has a local dependency and the build executor is called in a Windows machine the following error happen:

ERROR  pyproject.toml not found in /C:/Users/

That happens because the @nxlv/python plugin uses the output of the poetry export command, and the pattern for Mac/Linux is: -e file:///Users/... and for Windows is -e file:///C:/Users/.

The resolved location for Mac/Linux is /Users/... and /C:/Users/ for Windows.

Expected Behavior

The resolved location should stay as-is for Mac/Linux and change from /C:/Users/ to C:/Users/ for Windows.

@lucasvieirasilva lucasvieirasilva merged commit 6b65b68 into main Aug 12, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 12, 2024
## [19.0.2](nx-python-v19.0.1...nx-python-v19.0.2) (2024-08-12)

### Bug Fixes

* **nx-python:** resolve poetry export local path for windows ([#244](#244)) ([6b65b68](6b65b68))
Copy link

🎉 This PR is included in version 19.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant