Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-python): add support for nx releases #246

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

lucasvieirasilva
Copy link
Owner

@lucasvieirasilva lucasvieirasilva commented Sep 18, 2024

This PR adds support for Nx releases

Current Behavior

All the current features should work as-is.

Expected Behavior

Adds support for Nx release commands.

Related Issue(s)

Re #122

Additional notes

SonarQube is raising a bunch of comments that I won't address because I want this implementation to be as closed as possible with the @nx/js implementation (once they make the releases more modular, I can refactor those files)

@lucasvieirasilva lucasvieirasilva merged commit 9614843 into main Sep 18, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 18, 2024
# [19.1.0](nx-python-v19.0.2...nx-python-v19.1.0) (2024-09-18)

### Features

* **nx-python:** add support for nx releases ([#246](#246)) ([9614843](9614843))
Copy link

🎉 This PR is included in version 19.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@JamesHenry
Copy link

@lucasvieirasilva Let's stay in touch about this, I have an update to versioning coming which will require a tiny amount of python specific code on top from you instead of this massive amount of duplication.

Are you on the community discord? You can DM me there

@lucasvieirasilva
Copy link
Owner Author

@JamesHenry, thanks for letting me know, great, I pretty much duplicated a bunch of stuff from the official Nx release code and changed the Python specifics.

Yes, I am in the community discord, I'll keep watching the Nx releases, and once you guys have this update, we can talk again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants