fix(nx-python): remove direct dependency on nx #255
Conversation
packages/nx-python/package.json
Outdated
| "ora": "5.3.0", | ||
| "semver": "^7.5.3" | ||
| "semver": "^7.5.3", | ||
| "nx": "20.1.2" |
There was a problem hiding this comment.
Hey @FrozenPandaz, thanks for raising this PR.
The nx dependency still in the package.json, and I also noticed you are removing some other packages.
That doesn't feel right, could you check pls?
There was a problem hiding this comment.
Oh no, I'm so sorry. Funnily enough, the nx dependency-check lint rule acted up for me locally. I'll take a look at that but it's not related to this PR.
I ignored the imports from the lint rule... It's still okay for you to import nx without depending on it because you have a peer dependency.. it should be resolveable. Ideally our lint rule wouldn't warn about it. Also ideally, you should not import directly from nx but we recognize that there are some private APIs which you are using. We'll take note of it and see if we can expose those as @nx/devkit utils for you to move to.
There was a problem hiding this comment.
don't worry mate, thanks for pushing a fix for that
FrozenPandaz
force-pushed
the
rm-nx-dep
branch
from
c3c8a4e to
0697110
Compare
## [20.0.1](nx-python-v20.0.0...nx-python-v20.0.1) (2024-11-25) ### Bug Fixes * **nx-python:** remove direct dependency on nx ([#255](#255)) ([762db7d](762db7d))
|
🎉 This PR is included in version 20.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Current Behavior
@nxlv/pythonhas a direct dependency onnxlocked to20.1.2. In workspaces which are not on Nx20.1.2(either older or newer), this causes there to be multiple versions of Nx in the workspace. Nx does its best to mitigate these sorts of issues but ideally, Nx plugins do not bring in their own version ofnx.Expected Behavior
The way it should work for Nx plugins is that they all depend on
@nx/devkit.@nx/devkititself has a peer dependency on the proper range of Nx which can be used with that particular version of@nx/devkit. For example,@nx/devkit@20.1.2works with Nx 19 - 21. Nx Plugins should inherit thispeerDependencythrough it's dependency on@nx/devkitrather than directly depending onnx. What this means for workspaces is that all of the plugins used in a workspace should depend on the one main version ofnxspecified by that workspace.So what I've done in this PR is remove the dependency from
@nxlv/pythonontonx.@nxlv/pythongoes from having an explicit dependency onnx@20.1.2to having apeerDependencyon Nx 19 - 21. ThispeerDependencywill be updated as you update@nxlv/python's dependency on@nx/devkit. This solves issues that users using versions of Nx other than20.1.2may encounter due to having multiple versions of Nx present in their workspace.Please let me know if you have any questions. :)
Related Issue(s)
Fixes #