-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iPad Bottom Sheet, but at the Bottom β¨ #100
Conversation
β¦not float, and to override the width of the sheet.
β¦eyboard is opened.
Amazing pull request. First of all, thank you for your work! I will review it later today. |
Ah, I see the issue that turned up in the CI, I'm currently fixing it! |
Sources/BottomSheet/BottomSheetView/BottomSheetView+Calculations.swift
Outdated
Show resolved
Hide resolved
Sources/BottomSheet/BottomSheetView/BottomSheetView+Calculations.swift
Outdated
Show resolved
Hide resolved
Sources/BottomSheet/BottomSheetView/BottomSheetView+HelperViews.swift
Outdated
Show resolved
Hide resolved
Sources/BottomSheet/BottomSheetView/BottomSheetView+Calculations.swift
Outdated
Show resolved
Hide resolved
Amazing pull request. Mentioned a couple of thinks (most if it really small changes to so that you match my code style). π₯³ Thank you for your clean contribution β€οΈ |
Oh and before I forget to mention it. Please also add your changes to the changelog and update the version in the podspec file accordingly. Also if you have any questions regarding my review please ask. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; I mentioned a couple of things that I would like to be changed. However if you want i can merge it now and change the rest myself. Youβve already been a big help.
Sources/BottomSheet/BottomSheet+ViewModifiers/BottomSheet+AccountForKeyboardHeight.swift
Outdated
Show resolved
Hide resolved
Sources/BottomSheet/BottomSheet+ViewModifiers/BottomSheet+AccountForKeyboardHeight.swift
Outdated
Show resolved
Hide resolved
Thanks for merging! π |
Hi!
I like this library, but it would be awesome if the bottom sheet could actually be at the bottom on an iPad. π
So... that's where this PR is for! I've also added a modifier that enables you to override the sheet width, and a modifier that adds bottom padding to the main content if the keyboard is opened (which should fix this issue I believe: #97 ).
iPad Demo
View's Code
Without the keyboard auto adjust
before.mp4
With the keyboard auto adjust
after.mp4
I'm looking forward to your feedback! π