Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added automatic embed and minify of style.css and made website respon… #3

Merged
merged 8 commits into from
May 21, 2022

Conversation

takenX10
Copy link
Contributor

What?

Added automatic embed and minify of style.css file, made website responsive.

How?

  • To embed the style.css file I used the default go embed package
  • I minifyed the style.css file with this package made by tdewolff.
  • I made the website responsive with grids, and removed some file descriptions when the screen is too small with media query.
  • I managed to make really long names wrap around correctly.

Test

I tested this configuration in these devices:

  • 1920 x 1080 display
  • 1280 x 720 display
  • Galaxy Note 20
  • Galaxy Note 20 Ultra
  • Galaxy S10/S10+
  • Galaxy S20
  • Galaxy S20 Ultra
  • Galaxy S20+
  • Galaxy S5
  • IPad
  • IPhone 11 Pro
  • IPhone 11 Pro max
  • IPhone 12/13 + pro
  • IPhone 12/13 mini
  • IPhone 12/13 pro max
  • IPhone se second gen
  • Kindle fire HDX

Screenshots

image
image
image

Other suggestions

  • By losing a little bit of bytes, we can add a class to the memory paragraph, and make it text-align: center; on media query, that would make the memory more readable when the name is longer than one line but smaller than 2 (e.g. with medium sizes screen like IPad or Kindle with the long name I used on the screenshot).

@takenX10 takenX10 force-pushed the responsive-addition branch from 15436e7 to 1d2aa6c Compare May 18, 2022 10:04
@lucat1 lucat1 merged commit 24d2ce7 into lucat1:main May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants