LDEV-1175 Fixing NullPointerException when referencing adminSync object from Ad… #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…min.java Fixed dumb error in last commit Fixed my bad commit for hopefully the last time
cchadwickmc
changed the title
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the NullPointerException in Admin.java due to the AdminSync object not being present. We decided to create a new type of AdminSync (AdminSyncNullObject) even though the implementation is identical to AdminSyncNotSupported, just in case there were future plans for AdminSyncNotSupported that would have broken Admin.java when it tried to instantiate one.